Larra/larra
10
4
Fork 0
Code Issues 15 Pull requests Projects 1 Releases Packages Wiki Activity Actions

Add message sending to roster #23

Merged
sha512sum merged 2 commits from feature_message_roster into main 2024-12-27 12:16:17 +00:00
Conversation 0 Commits 2 Files changed 13 +596 -83
sha512sum commented 2024-12-21 08:31:35 +00:00
Owner
Copy link
No description provided.
sha512sum added 1 commit 2024-12-21 08:31:35 +00:00
Add message serialization and deserialization
All checks were successful
PR Check / on-push-commit-check (push) Successful in 12m18s
Details
64e2aeb8aa
sha512sum added this to the Main project 2024-12-21 08:31:45 +00:00
sha512sum removed this from the Main project 2024-12-21 10:40:46 +00:00
sha512sum force-pushed feature_message_roster from 64e2aeb8aa to cd685ba101 2024-12-21 15:56:39 +00:00 Compare
sha512sum force-pushed feature_message_roster from cd685ba101 to f4a2338dd1 2024-12-21 17:16:06 +00:00 Compare
sha512sum added 1 commit 2024-12-22 13:23:40 +00:00
Use one std::visit instead std::visit for call
Some checks failed
PR Check / on-push-commit-check (push) Has been cancelled
Details
73c1c4e8ca
sha512sum force-pushed feature_message_roster from 73c1c4e8ca to 1d870fbe54 2024-12-22 13:24:11 +00:00 Compare
sha512sum force-pushed feature_message_roster from 1d870fbe54 to 9d95d08ab7 2024-12-22 14:37:46 +00:00 Compare
Ivan-lis reviewed 2024-12-22 22:55:59 +00:00
.forgejo/workflows/pr_check.yaml Outdated
@ -14,3 +14,3 @@
pacman -S --noconfirm gtk4 gtkmm-4.0 boost spdlog fmt libxml++-5.0 gtest
- name: Setup environment - Install LLVM-19.1.3
- name: Setup environment - Install LLVM-19.1.5
Ivan-lis commented 2024-12-22 22:55:59 +00:00
Member
Copy link

Could you also update in Dockerfile?

Could you also update in Dockerfile?
sha512sum marked this conversation as resolved
Ivan-lis reviewed 2024-12-22 22:57:53 +00:00
tests/message.cpp Outdated
@ -0,0 +42,4 @@
TEST(Serialize, Message) {
auto expected =
"<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<message from=\"user1@server.i2p\" to=\"user2@server.i2p\" type=\"chat\" id=\"1\" "
Ivan-lis commented 2024-12-22 22:57:53 +00:00
Member
Copy link

Maybe use R"()" to get rid of double quote escaping?

Maybe use `R"()"` to get rid of double quote escaping?
👍 1
sha512sum marked this conversation as resolved
sha512sum force-pushed feature_message_roster from 9d95d08ab7 to 6064be2b71 2024-12-24 06:18:38 +00:00 Compare
sha512sum added 2 commits 2024-12-24 06:27:17 +00:00
.
Some checks are pending
PR Check / on-push-commit-check (push) Waiting to run
Details
e750d184a6
sha512sum force-pushed feature_message_roster from e750d184a6 to 00e885a9e6 2024-12-24 06:32:38 +00:00 Compare
sha512sum added 1 commit 2024-12-24 08:50:28 +00:00
.
Some checks failed
PR Check / on-push-commit-check (push) Failing after 16m18s
Details
b3a4757b2f
sha512sum added 1 commit 2024-12-24 09:08:08 +00:00
.
Some checks failed
PR Check / on-push-commit-check (push) Failing after 17m8s
Details
fe5b652240
sha512sum added 2 commits 2024-12-24 10:59:01 +00:00
.
All checks were successful
PR Check / on-push-commit-check (push) Successful in 16m21s
Details
8019371d46
sha512sum force-pushed feature_message_roster from 8019371d46 to b247307fc4 2024-12-24 11:22:37 +00:00 Compare
sha512sum added 1 commit 2024-12-24 11:26:41 +00:00
.
Some checks failed
PR Check / on-push-commit-check (push) Failing after 1m27s
Details
83dc1462cb
sha512sum force-pushed feature_message_roster from 83dc1462cb to b247307fc4 2024-12-24 11:32:34 +00:00 Compare
sha512sum force-pushed feature_message_roster from b247307fc4 to cda854553c 2024-12-24 11:41:46 +00:00 Compare
sha512sum changed title from WIP: Add message sending to roster to Add message sending to roster 2024-12-24 11:50:56 +00:00
sha512sum merged commit cda854553c into main 2024-12-27 12:16:17 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Larra/larra#23
No description provided.
Delete branch "feature_message_roster"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?